test: add optional throw fn to expectsError

[BridgeAR]

This is mainly a style thing but I think it's pretty nice to add the throwing function directly to common.expectsError instead of wrapping that into the throw function as it's done most of the time.

I thought I just create this as a example and I only changed a few tests accordingly.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

test

[benjamingr]

Change LGTM, I don't think I've ever used an expectsError without throws before (except in callbacks).

[Trott]

@nodejs/testing

[tniessen]

Code LGTM.

[refack]

Docs ttps://github.com/nodejs/node/blob/master/test/common/README.md

[refack]

@BridgeAR You're the one who's gonna have to resolve all the conflicts in expectsError 😉

[BridgeAR]

@refack I added the documentation.

About resolving the conflicts: I think it would be best to first merge this as is and then change all those calls over time.

[refack]

Pre-land CI: https://ci.nodejs.org/job/node-test-pull-request/9043/

[addaleax]

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the dont-land-on label.

[refack]

@BridgeAR IMHO if you apply the PRs to test/common in order they should land cleanly, I believe you could group them all into a single backport PR.
Alternatively (if you haven't tried it already) @addaleax could you try cherry picking them in chronological order. We did several "conflicting" changes in the last couple of weeks, so I'm assuming they will only land cleanly if picked in the same order they landed.

[MylesBorins]

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

[BridgeAR]

This function does not exist in v.6 so backporting is obsolete.