deps: cherry-pick 866ee63 from upstream V8#13630
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
deps: cherry-pick 866ee63 from upstream V8#13630targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
Original commit message:
[string] Re-enable result caching for String.p.split
Runtime::kStringSplit's result caching is only enabled when limit equals
kMaxUInt32.
BUG=v8:6463
Review-Url: https://codereview.chromium.org/2923183002
Cr-Commit-Position: refs/heads/master@{nodejs#45724}
Fixes: nodejs#13445
nodejs-github-bot
added
the
v8 engine
Member
Author
|
Ping @nodejs/v8 |
bnoordhuis
approved these changes
Jun 19, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM, I suppose, but is there a reason why this hasn't been back-ported upstream?
Member
Author
|
It has been backported to 6.0 only. Quoting @bmeurer:
|
Member
|
LGTM, cc @schuay |
Member
Author
Member
Author
|
Thank you. Landed in 7cdcca7 |
targos
added a commit
that referenced
this pull request
Jun 20, 2017
Original commit message:
[string] Re-enable result caching for String.p.split
Runtime::kStringSplit's result caching is only enabled when limit equals
kMaxUInt32.
BUG=v8:6463
Review-Url: https://codereview.chromium.org/2923183002
Cr-Commit-Position: refs/heads/master@{#45724}
PR-URL: #13630
Fixes: #13445
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #13445
@nodejs/v8
I did not update V8_PATCH_LEVEL because V8 5.9 is still supported.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8