Removed redundant mentions to error codes in doc/api/errors.md#13627
Closed
jklepatch wants to merge 1 commit intonodejs:masterfrom
Closed
Removed redundant mentions to error codes in doc/api/errors.md#13627jklepatch wants to merge 1 commit intonodejs:masterfrom
jklepatch wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
Trott
approved these changes
Jun 12, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Thanks for the pull request. LGTM!
Contributor
|
/cc @jasnell |
TimothyGu
approved these changes
Jun 12, 2017
danbev
approved these changes
Jun 12, 2017
lpinca
approved these changes
Jun 12, 2017
cjihrig
approved these changes
Jun 12, 2017
tniessen
pushed a commit
that referenced
this pull request
Jun 14, 2017
PR-URL: #13627 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 2f34bf0 🎉 Thank you for your contribution. In the future, please try to follow our guidelines for commit messages. You might also want to configure git to automatically detect lines with trailing whitespace as this can cause problems when applying your changes. |
This was referenced Jun 14, 2017
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jun 22, 2017
2 tasks
Member
|
This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the |
Member
|
@danbev @Trott @lpinca @TimothyGu @cjihrig Does any of you have the time to backport? This seems like a great candidate for backporting to avoid future conflicts. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 11, 2017
PR-URL: nodejs#13627 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
Member
|
Backport in #14175 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this issue:
"Every description of each error code starts with one of two unnecessarily-verbose phrases that should probably be removed:"
https://github.com/nodejs/node/blob/master/doc/api/errors.md#nodejs-error-codes
Affected core subsystem(s)
doc/api/errors.md