configure: added mips64el to valid_arch#13620
Closed
thelostone-mc wants to merge 1 commit intonodejs:masterfrom
Closed
configure: added mips64el to valid_arch#13620thelostone-mc wants to merge 1 commit intonodejs:masterfrom
thelostone-mc wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
Member
|
Could you change your commit message to: (as per the Contributing Guidelines)? If you don't have time it can be rewritten by whoever lands this. |
gibfahn
approved these changes
Jun 11, 2017
Member
|
cc/ @nodejs/build @bnoordhuis |
thelostone-mc
force-pushed
the
master
branch
2 times, most recently
from
41ea903 to
9e59512
Compare
bnoordhuis
approved these changes
Jun 12, 2017
refack
approved these changes
Jun 12, 2017
configure
Outdated
Contributor
There was a problem hiding this comment.
nitty bitty nit: spaces after commas
(at present we don't lint test the .py files)
Contributor
|
/cc @nodejs/lts original issue was about the |
Member
I think we can follow our standard backporting procedure on this, so we'll land in master and include in the next v6.x release (or the one after). |
cjihrig
approved these changes
Jun 12, 2017
jasnell
approved these changes
Jun 12, 2017
mhdawson
approved these changes
Jun 12, 2017
jasnell
pushed a commit
that referenced
this pull request
Jun 13, 2017
PR-URL: #13620 Fixes: #13616 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed in 224dbb1 |
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
PR-URL: #13620 Fixes: #13616 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
PR-URL: #13620 Fixes: #13616 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
PR-URL: #13620 Fixes: #13616 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
added a commit
that referenced
this pull request
Aug 1, 2017
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.
Notable Changes:
* configure:
- add mips64el to valid_arch (Aditya Anand)
- #13620
* crypto:
- Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
- #13279
- #12402
- https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
- upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
- #12913
* http:
- parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
- #13206
- Agent construction can now be envoked without `new` (cjihrig)
- #12927
* zlib:
- node will now throw an Error when zlib rejects the value of windowBits,
instead of crashing (Alexey Orlenko)
- #13098
PR-URL: #14356
MylesBorins
added a commit
that referenced
this pull request
Aug 1, 2017
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.
Notable Changes:
* configure:
- add mips64el to valid_arch (Aditya Anand)
- #13620
* crypto:
- Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
- #13279
- #12402
- https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
- upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
- #12913
* http:
- parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
- #13206
- Agent construction can now be envoked without `new` (cjihrig)
- #12927
* zlib:
- node will now throw an Error when zlib rejects the value of windowBits,
instead of crashing (Alexey Orlenko)
- #13098
PR-URL: #14356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13616
configure: add mips64el to valid_arch
Files Changed
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)