Skip to content

url: do not pass WHATWG host to http.request#13409

Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen:no-host
Closed

url: do not pass WHATWG host to http.request#13409
tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen:no-host

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jun 2, 2017

As we explicitely state that hostname is an alias for host, we should avoid passing different (or even invalid) values for host, even if hostname is preferred. There is no reason to pass an invalid value for host to http.request().

Ref: #10638

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@tniessen tniessen added http Issues or PRs related to the http subsystem. semver-minor PRs that contain new features and should be released in the next minor version. url Issues and PRs related to the legacy built-in url module. labels Jun 2, 2017
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 2, 2017
@addaleax
Copy link
Member

addaleax commented Jun 2, 2017

Could you explain how this is semver-minor? How does it add something to the API?

@DavidTPate
Copy link

DavidTPate commented Jun 2, 2017

Yeah, this doesn't appear to be a semver-minor the changes are internal and don't impact the external APIs.

@jasnell
Copy link
Member

jasnell commented Jun 2, 2017

semver-patch is appropriate here.

@jasnell jasnell removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 2, 2017
@tniessen
Copy link
Member Author

tniessen commented Jun 2, 2017

Sorry, my bad, must have mixed that up with another PR.

@tniessen
Copy link
Member Author

tniessen commented Jun 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8456/

tniessen added a commit that referenced this pull request Jun 4, 2017
@tniessen
url: do not pass WHATWG host to http.request
4d89e3c 
PR-URL: #13409
Refs: #10638
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@tniessen
Copy link
Member Author

tniessen commented Jun 4, 2017

Landed in 4d89e3c.

@tniessen tniessen closed this Jun 4, 2017
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@tniessen @jasnell
url: do not pass WHATWG host to http.request
d4d138c 
PR-URL: #13409
Refs: #10638
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @addaleax @DavidTPate @jasnell @nodejs-github-bot