stream, doc: resume a stream after pipe() and unpipe()#13329
Closed
mcollina wants to merge 1 commit intonodejs:masterfrom
Closed
stream, doc: resume a stream after pipe() and unpipe()#13329mcollina wants to merge 1 commit intonodejs:masterfrom
mcollina wants to merge 1 commit intonodejs:masterfrom
Conversation
Clarifies the behavior of streams when _readableState.flowing is false. resume() must be called explicitly for the 'data' event to be emitted again. Fixes: nodejs#1041
mcollina
added
doc
nodejs-github-bot
added
doc
Member
Author
|
I like that, especially having a code example alongside the doc. |
dmail
reviewed
May 31, 2017
| const pass = new PassThrough(); | ||
| const writable = new Writable(); | ||
|
|
||
| pass.pipe(writable); pass.unpipe(writable); // flowing is now false |
There was a problem hiding this comment.
I think that would be better to keep an instruction per line
pass.pipe(writable);
pass.unpipe(writable);
// flowing is now false(I had written those on the same line back in 2015 but that was a bad idea)
jasnell
approved these changes
Jun 1, 2017
Member
Author
Closed
3 tasks
Contributor
|
I've landed this in v6.x-staging. Let me know if it should be backed out |
Member
Author
|
@MylesBorins this is ok to be backported. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the behavior of streams when _readableState.flowing is
false. resume() must be called explicitly for the 'data' event to
be emitted again.
Fixes: #1041
Checklist
Affected core subsystem(s)
doc, stream