errors,util: migrate to use internal/errors.js#13293
Closed
bidipyne wants to merge 1 commit intonodejs:masterfrom
bidipyne:my-branch
Closed
errors,util: migrate to use internal/errors.js#13293bidipyne wants to merge 1 commit intonodejs:masterfrom bidipyne:my-branch
bidipyne wants to merge 1 commit intonodejs:masterfrom
bidipyne:my-branch
Conversation
nodejs-github-bot
added
the
util
targos
added
the
semver-major
addaleax
added
the
errors
jasnell
approved these changes
Jun 1, 2017
Member
Member
mhdawson
approved these changes
Jun 2, 2017
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM once --expose-internals is removed.
test/parallel/test-util-inspect.js
Outdated
Member
There was a problem hiding this comment.
I don' think we need --expose-internals
Contributor
Author
|
Done as per suggestion. Thanks! @mhdawson |
Member
|
@bidipyne thanks :) CI run: https://ci.nodejs.org/job/node-test-pull-request/8439/ |
jasnell
pushed a commit
that referenced
this pull request
Jun 2, 2017
PR-URL: #13293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed in 1609899 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util.js
ref: #11273
This is my first contribution in node. I read and understood the contribution guidelines, please review and suggest.
@jasnell
Thanks.