errors,process: migrate to use internal/errors.js#13285
errors,process: migrate to use internal/errors.js#13285sreepurnajasti wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
errors
lib/internal/errors.js
Outdated
There was a problem hiding this comment.
long line here. please line wrap at <= 80 chars.
Running make lint should catch these :-)
There was a problem hiding this comment.
@jasnell Unfortunately, on jslint test, this error is not showed up. Now, this is done. Thank you.
|
CI run good, will land tomorrow once 48 hours has passed. |
|
Actually 48 hours is already up landing. |
|
Actually looking again as part of landing I think its better to avoid adding: // Flags: --expose-internals and just use TypeError instead of errors.TypeError etc when possible. @sreepurnajasti can you make that change? |
|
This needs a rebase before it can land. Thank you! |
|
@sreepurnajasti can you can rebase and remove the use of --expose-internals. |
|
New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/8441/ |
| E('ERR_SOCKET_BAD_PORT', 'Port should be > 0 and < 65536'); | ||
| E('ERR_SOCKET_DGRAM_NOT_RUNNING', 'Not running'); | ||
| E('ERR_V8BREAKITERATOR', 'full ICU data not installed.' + | ||
| 'See https://github.com/nodejs/node/wiki/Intl'); |
There was a problem hiding this comment.
There should be a space after installed., right?
|
CI run good, landing. Will add space. |
|
Landed as 062071a |
PR-URL: #13285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
jasnell
added
the
semver-major
6 participants
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib/internal/process.js
lib/internal/errors.js
ref: #11273