Closed
Conversation
Trott
added
doc
nodejs-github-bot
added
doc
lpinca
approved these changes
May 29, 2017
jasnell
approved these changes
May 29, 2017
Member
Author
|
Landed in 102e1aa |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 31, 2017
PR-URL: nodejs#13274 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
If any part of this needs to be backported to v8.x, then a separate backport PR should be opened. |
Member
Author
Member
|
234353a was a semver-major that I do not believe landed in time to make the 8.x cut so I think we're good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @TimothyGu
Checklist
Affected core subsystem(s)
doc errors