test: improve async hooks test error messages

[addaleax]

Improve error messages in the async hooks tests, mostly by removing
unhelpful message parameters for assertions.

(@Trott, maybe we could have a lint rule that forbids literals as messages if this PR is somewhat well-received?)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test/async_hooks

[AndreasMadsen]

Rubber stamp LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/

[refack]

From a partial scan I agree with 97% of removals.
Some might have value... like: assert.strictEqual(code, 1, 'exit code 1');
Would you wait a day or two before landing, I really want to review them all (It will be a shame to lose good information if it's in there)

[refack]

(@Trott, maybe we could have a lint rule that forbids literals as messages if this PR is somewhat well-received?)

Sounds good, but maybe a little bit more lax, like if it's more than n characters long, or has at least 4 white space groups (meaning 5 words), or has some keywords like should, it might be good as well.
[edit] meanwhile it should be communicated to Collaborators not to approve these sort of unhelpful messages, as they actually hide the default which is better.

[addaleax]

Some might have value... like: assert.strictEqual(code, 1, 'exit code 1');

I wouldn’t agree. exit code 1 is an unhelpful error message, because it just states the expected result; but that I can easily look up by looking at where the stack trace points. Providing the actual exit code is a lot more helpful.

Would you wait a day or two before landing, I really want to review them all (It will be a shame to lose good information if it's in there)

Sure, this isn’t urgent.

[jasnell]

ping @refack ... have you had a chance to review yet?

[refack]

halfway there.

[trevnorris]

Changes look good. Thanks for the cleanup.

[addaleax]

Rebased. @refack I think the “a day or two before landing” have passed by now, are you okay with reviewing this later and fixing up anything you’d like to see addressed yourself?

CI: https://ci.nodejs.org/job/node-test-commit/10331/

[refack]

Rebased. @refack I think the “a day or two before landing” have passed by now, are you okay with reviewing this later and fixing up anything you’d like to see addressed yourself?

CI: https://ci.nodejs.org/job/node-test-commit/10331/

Yep.

[addaleax]

Landed in 1dc3272