src: whitelist new options for NODE_OPTIONS by sam-github · Pull Request #13002 · nodejs/node

sam-github · 2017-05-12T19:43:44Z

Add --inspect-port, --napi-modules, --trace-event-categories

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

src

sam-github · 2017-05-12T19:57:48Z

ci: https://ci.nodejs.org/job/node-test-pull-request/8046/

refack · 2017-05-12T20:07:27Z

doc/api/cli.md

You must have had a reason to leave those out on the first run?
They will make a very weird effect...
inspect-port on the other hand is benign if used alone.

Useful when running node via a shell script, and wanting to cause node when it runs to break on first line. I'm not sure how much thought went into this initially. I can leave only the -port if that's preferred.

I'm ±0 on these.

ok, I'll give it a couple days to see if anyone feels strongly

Seems useful to have, although if the node process spawns a child will that child also try to connect to the inspector?

yes, so don't do that unless the port is 0

refack · 2017-05-12T20:23:13Z

Ignore the fail on macOS (and maybe freeBSD) they are flakes #12964 (comment)

Trott · 2017-05-14T03:17:31Z

No idea if it would be difficult to accomplish or not, but a test for #12941 (assuming this fixes that issue) would be great.

Or at least some kind of test for the functionality change here?

sam-github · 2017-05-16T21:29:48Z

@Trott #12941 is a different bug, something is wrong in the cluster pre-fork arg parsing, unrelated (though perhaps this could be used as work-around)

refack · 2017-05-16T21:34:12Z

If this lands before #12949 I can add tests for --inspect, --inspect-brk, and --inspect-port

sam-github · 2017-05-16T21:49:49Z

I removed support for --inspect, --inspect-brk, adding unit tests for every option passed via env var is a bit more than I can manage. I might remove support for --trace-event-categories as well, node has the unfortunate habit of randomly requiring either a = or a before an option's value :-(, but I'm trying harder for it because trace events are absolutely the kind of thing I'd want to configure via env var.

refack

Nit

refack · 2017-05-16T21:56:11Z

doc/api/cli.md

"--inspect-port"

mhdawson

LGTM

sam-github · 2017-05-17T17:25:39Z

ci: https://ci.nodejs.org/job/node-test-pull-request/8131/

sam-github · 2017-05-17T19:36:51Z

Only failure was unrelated, sequential/test-net-connect-local-error on one of the FreeBSDs, I'm going to land this.

Add --inspect-*, --napi-modules, --trace-event-categories Remove --prof-process, like -p and -e, it causes node to do something other than run node js scripts. PR-URL: nodejs#13002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

sam-github · 2017-05-30T21:43:58Z

See #12677

MylesBorins · 2017-06-23T18:24:15Z

I've added don't land for v6.x

If any of these flags should be backported please feel free to open a separate PR

sam-github · 2017-07-25T16:45:31Z

backported in #12677

Add --debug-*, --napi-modules Remove --prof-process, like -p and -e, it causes node to do something other than run node js scripts. PR-URL: nodejs#13002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Add --debug-*, --napi-modules Remove --prof-process, like -p and -e, it causes node to do something other than run node js scripts. Backport-PR-URL: #12677 PR-URL: #13002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 12, 2017

sam-github mentioned this pull request May 12, 2017

Programatically setting the debug flag has no effects #12941

Closed

refack approved these changes May 12, 2017

View reviewed changes

jasnell approved these changes May 12, 2017

View reviewed changes

cjihrig approved these changes May 12, 2017

View reviewed changes

mscdex added the cli Issues and PRs related to the Node.js command line interface. label May 13, 2017

sam-github force-pushed the add-inspect-to-node-options branch 2 times, most recently from 39ccc51 to 2472f17 Compare May 16, 2017 21:52

refack suggested changes May 16, 2017

View reviewed changes

doc/api/cli.md Outdated

Copy link

Contributor

refack May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"--inspect-port"

refack mentioned this pull request May 16, 2017

debugger: bind to random port with --inspect=0 #8080

Closed

sam-github force-pushed the add-inspect-to-node-options branch from 0d3f956 to d6ce121 Compare May 16, 2017 23:02

refack approved these changes May 16, 2017

View reviewed changes

mhdawson approved these changes May 17, 2017

View reviewed changes

sam-github force-pushed the add-inspect-to-node-options branch from d6ce121 to 42d7e61 Compare May 17, 2017 17:11

sam-github force-pushed the add-inspect-to-node-options branch from 42d7e61 to d6cd466 Compare May 17, 2017 19:40

sam-github merged commit d6cd466 into nodejs:master May 17, 2017

sam-github deleted the add-inspect-to-node-options branch May 17, 2017 19:42

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

sam-github mentioned this pull request May 30, 2017

(v6.x backport) src: allow CLI args in env with NODE_OPTIONS #12677

Closed

4 tasks

refack mentioned this pull request Jun 11, 2017

refactor test/inspector #13622

Closed

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the dont-land-on-v6.x label Jun 23, 2017

MylesBorins added backported-to-v6.x and removed dont-land-on-v6.x labels Oct 16, 2017

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

Uh oh!

Conversation

sam-github commented May 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

sam-github commented May 12, 2017

Uh oh!

refack May 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sam-github May 12, 2017

Choose a reason for hiding this comment

Uh oh!

refack May 12, 2017

Choose a reason for hiding this comment

Uh oh!

sam-github May 12, 2017

Choose a reason for hiding this comment

Uh oh!

gibfahn May 12, 2017

Choose a reason for hiding this comment

Uh oh!

sam-github May 16, 2017

Choose a reason for hiding this comment

Uh oh!

refack commented May 12, 2017

Uh oh!

Trott commented May 14, 2017

Uh oh!

sam-github commented May 16, 2017

Uh oh!

refack commented May 16, 2017

Uh oh!

sam-github commented May 16, 2017

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

refack May 16, 2017

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

sam-github commented May 17, 2017

Uh oh!

sam-github commented May 17, 2017

Uh oh!

sam-github commented May 30, 2017

Uh oh!

MylesBorins commented Jun 23, 2017

Uh oh!

sam-github commented Jul 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

sam-github commented May 12, 2017 •

edited

Loading

refack May 12, 2017 •

edited

Loading