Patch V8 API to be ABI compatible with v5.9.#12878
Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Closed
Patch V8 API to be ABI compatible with v5.9.#12878MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
Comparing with my own attempt in #12875, this is missing:
I would say that this patch has a somewhat more elegant solution for the changed value of |
3 tasks
Contributor
Author
|
hey @addaleax didn't see your original patch. Want me to close this? |
Member
|
@MylesBorins I don’t really care that much… If you want, feel free to cherry-pick the changes listed above (plus 932bd46 and maybe cbf3ecf) to this PR and I’ll close mine. ¯\_(ツ)_/¯ |
Contributor
Author
|
Closing in favor of #12875 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch to make V8 5.8 ABI compatible with V8 5.9
I did not include a patch to bump the NODE_MODULES version. Do we plan to bump it for each ABI change prior to release?
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/690/
CI: https://ci.nodejs.org/job/node-test-pull-request/7926/