Skip to content

test: add callback to fs.close() in test-fs-chmod#12795

Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:test-fs-chmod-cb
Closed

test: add callback to fs.close() in test-fs-chmod#12795
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:test-fs-chmod-cb

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented May 2, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, fs

To avoid [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.

@vsemozhetbyt vsemozhetbyt added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels May 2, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 2, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7806/

@Trott
Copy link
Member

Trott commented May 2, 2017

Maybe instead of common.noop, use assert.ifError? (I'm OK if you don't. Just an idea.)

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 2, 2017 •
edited
Loading

@Trott This makes sense) Is assert.ifError static? Can I just fs.close(fd, assert.ifError);?

@jasnell
Copy link
Member

jasnell commented May 2, 2017

@vsemozhetbyt ... yes, in this particular case assert.ifError should work just fine.

@vsemozhetbyt
test: add callback to fs.close() in test-fs-chmod
b157436 
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 2, 2017

Done. CI: https://ci.nodejs.org/job/node-test-pull-request/7813/

@vsemozhetbyt vsemozhetbyt mentioned this pull request May 2, 2017
Closed
Trott
Trott approved these changes May 2, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 4, 2017

Landed in 712596f

@vsemozhetbyt vsemozhetbyt deleted the test-fs-chmod-cb branch May 4, 2017 18:20
vsemozhetbyt added a commit that referenced this pull request May 4, 2017
@vsemozhetbyt
test: add callback to fs.close() in test-fs-chmod
712596f 
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@vsemozhetbyt
test: add callback to fs.close() in test-fs-chmod
f070ebd 
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: nodejs#12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
@vsemozhetbyt @gibfahn
test: add callback to fs.close() in test-fs-chmod
9937f5f 
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@vsemozhetbyt @gibfahn
test: add callback to fs.close() in test-fs-chmod
41d8815 
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@vsemozhetbyt @MylesBorins
test: add callback to fs.close() in test-fs-chmod
a47a9b7 
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@santigimeno santigimeno santigimeno approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vsemozhetbyt @Trott @jasnell @refack @santigimeno @lpinca @cjihrig @gibfahn