src: remove experimental warning for inspect#12352
Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove experimental warning for inspect#12352MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
4 tasks
Contributor
Author
|
/cc @jasnell |
MylesBorins
force-pushed
the
stable-inspect
branch
2 times, most recently
from
c1a1c11 to
72f936e
Compare
MylesBorins
force-pushed
the
stable-inspect
branch
from
72f936e to
92c3f90
Compare
MylesBorins
changed the title
* Removes "experimental" warning. Fixes: nodejs#11770 PR-URL: nodejs#12352 Reviewed-By: _tbd_ Reviewed-By: _tbd_
MylesBorins
force-pushed
the
stable-inspect
branch
from
92c3f90 to
4e6fdcd
Compare
Member
|
Looks like some ci failures tho |
Contributor
Author
|
Got a little overzealous removing things. Should work fine now... CI kicked off once more |
Member
|
Remove all the things! |
targos
approved these changes
Apr 12, 2017
cjihrig
approved these changes
Apr 12, 2017
Contributor
Author
|
Are people ok with this landed in less than 48 hours? |
Member
|
I'm good with it, yes. It would be good to get this in before I do the RC.0 build |
aqrln
approved these changes
Apr 12, 2017
Contributor
|
I personally would greatly prefer if some sort of generic URL was printed along with this change, not sure if that is standardized enough yet? |
eugeneo
approved these changes
Apr 12, 2017
Contributor
Author
|
@Fishrock123 there is another thread for changing the message, we couldn't reach consensus on that so I wanted to get this in first |
ofrobots
approved these changes
Apr 12, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 13, 2017
* Removes "experimental" warning. Fixes: #11770 PR-URL: #12352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Member
|
Landed in a4125a3 |
14 tasks
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Apr 14, 2017
3 tasks
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2017
PR-URL: #12408 Ref: #12352 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
PR-URL: #12408 Ref: #12352 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12408 Ref: #12352 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12408 Ref: #12352 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is broken out of #11207 which also included changes to the message the inspector prints.
@joshgav's authorship is maintained on the commit
CI: https://ci.nodejs.org/job/node-test-pull-request/7343/