v7.x backport: http: avoid retaining unneeded memory#12112
Closed
lpinca wants to merge 1 commit intonodejs:v7.x-stagingfrom
Closed
v7.x backport: http: avoid retaining unneeded memory#12112lpinca wants to merge 1 commit intonodejs:v7.x-stagingfrom
lpinca wants to merge 1 commit intonodejs:v7.x-stagingfrom
Conversation
Prevent the events listeners of the sockets obtained with the HTTP upgrade mechanism from retaining unneeded memory. Ref: nodejs#11868 PR-URL: nodejs#11926 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
nodejs-github-bot
added
build
Member
Author
jasnell
approved these changes
Mar 29, 2017
gibfahn
approved these changes
Mar 31, 2017
MylesBorins
suggested changes
Apr 10, 2017
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
It looks like this change breaks spdy... we should hold off landing on v7 for now
Member
Author
|
I've proposed a PR to fix the issue on Is there anything I can do to move this forward or should I just close this? |
mscdex
added
the
memory
Member
Author
|
The issue with node-spdy has been addressed. Is it ok to land this on v7.x now? If we want to be extra careful and not include this in v7.x I'll close. |
Member
Author
|
Closing this as it doesn't make sense to backport to v7.x at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v7.x backport of #11926.