Skip to content

v6.x Backport - test, eslintrc: s/assert.equal/assert.strictEqual/#11795

Closed
gibfahn wants to merge 2 commits intonodejs:v6.x-stagingfrom
gibfahn:assert-strict-v6.x
Closed

v6.x Backport - test, eslintrc: s/assert.equal/assert.strictEqual/#11795
gibfahn wants to merge 2 commits intonodejs:v6.x-stagingfrom
gibfahn:assert-strict-v6.x

Conversation

@gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 11, 2017 •
edited
Loading

Backport of #10698

Currently includes #11775, as otherwise there'd be way too many conflicts. You want the last two commits. Rebased as #11775 landed, can now be landed as is.

If you want to see the manual changes (most worth reviewing) see the unsquashed branch, especially the last commit.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. v6.x labels Mar 11, 2017
@gibfahn gibfahn force-pushed the assert-strict-v6.x branch from d623d56 to cc95a6e Compare March 11, 2017 01:15
@gibfahn
Copy link
Member Author

gibfahn commented Mar 11, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit/8379/

EDIT: CI is green

Trott
Trott approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

needs to be rebased on the updated v6.x-staging branch

@gibfahn gibfahn force-pushed the assert-strict-v6.x branch from cc95a6e to 8042480 Compare March 22, 2017 17:55
@gibfahn
Copy link
Member Author

gibfahn commented Mar 22, 2017 •
edited
Loading

needs to be rebased on the updated v6.x-staging branch

Done

Note that the "you only need the last two commits because the first two are from #11775" still applies.

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 13, 2017

@gibfahn this needs a rebase, and likely will have some conflicts do to var -> let PR that landed

gibfahn added 2 commits April 14, 2017 09:14
@gibfahn
test: s/assert.equal/assert.strictEqual/
bf1b90c 
Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.
@gibfahn
assert, tools: enforce strict (not)equal in eslint
55b528e 
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.

Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.
@gibfahn gibfahn force-pushed the assert-strict-v6.x branch from 8042480 to 55b528e Compare April 14, 2017 08:14
@gibfahn
Copy link
Member Author

gibfahn commented Apr 14, 2017

Rebased, I originally cherry-picked these commits on top of the var->let PR, so no conflicts to resolve 🍀 .

MylesBorins pushed a commit that referenced this pull request Apr 14, 2017
@gibfahn @MylesBorins
test: s/assert.equal/assert.strictEqual/
a654502 
Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

Backport-PR-URL: #11795
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 14, 2017
@gibfahn @MylesBorins
assert, tools: enforce strict (not)equal in eslint
acd9bc3 
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.

Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.

Backport-PR-URL: #11795
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
@gibfahn
Copy link
Member Author

gibfahn commented Apr 15, 2017

@MylesBorins I think you landed this in a654502 and acd9bc3 , so I'll close. Let me know if that's wrong!

@gibfahn gibfahn closed this Apr 15, 2017
@gibfahn gibfahn deleted the assert-strict-v6.x branch April 15, 2017 07:37
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@gibfahn @MylesBorins
test: s/assert.equal/assert.strictEqual/
6f85c81 
Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

Backport-PR-URL: #11795
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@gibfahn @MylesBorins
assert, tools: enforce strict (not)equal in eslint
12c0ce7 
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.

Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.

Backport-PR-URL: #11795
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@gibfahn @andrew749
test: s/assert.equal/assert.strictEqual/
3c6dbbb 
Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

Backport-PR-URL: nodejs/node#11795
PR-URL: nodejs/node#10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@gibfahn @andrew749
assert, tools: enforce strict (not)equal in eslint
88a4ebc 
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.

Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.

Backport-PR-URL: nodejs/node#11795
PR-URL: nodejs/node#10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

Assignees

@jasnell jasnell

@MylesBorins MylesBorins

Labels

assert Issues and PRs related to the assert subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gibfahn @jasnell @MylesBorins @Trott @nodejs-github-bot