test: add two test cases for querystring#11481
Conversation
mscdex
added
the
querystring
|
I think just using 'test' for the subsystem in the first line of the commit is enough, as no change to the actual |
|
Ahh ok, now the tagging rule becomes apparent to me. Thanks! |
+ Check an empty substring: In `querystring`, if the `maxKeys` is 1 and the state machine finds an empty substring between separators, it should return an empty object. + Test invalid encoded strings: If provided string is an invalid encoded string in `query.parse`, it will not be encoded.
watilde
force-pushed
the
test-querystring
branch
from
ca83f15 to
6913df6
Compare
mscdex
changed the title
+ Check an empty substring: In `querystring`, if the `maxKeys` is 1 and the state machine finds an empty substring between separators, it should return an empty object. + Test invalid encoded strings: If provided string is an invalid encoded string in `query.parse`, it will not be encoded. PR-URL: #11481 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@addaleax ... just fyi, I was landing this PR just as your review came in so you're not listed on the reviewers |
|
Landed in dd2e135 |
|
@jasnell guess what I was just going to push to master! 😄 |
|
not landing in |
|
Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the |
|
Since this update was related to the breaking change of the querystring in v8.x, I replaced |
9 participants
This test will improve
querystringcoverage:The following lines will be called with the cases:
node/lib/querystring.js
Line 332 in 88035bc
node/lib/querystring.js
Line 399 in 88035bc
Checklist
make -j4 testAffected core subsystem(s)
test