Backport 11037 - v4.x - doc: change logical to bitwise OR in dns lookup#11181
Closed
thefourtheye wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
Backport 11037 - v4.x - doc: change logical to bitwise OR in dns lookup#11181thefourtheye wants to merge 1 commit intonodejs:v4.x-stagingfrom
thefourtheye wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: nodejs#11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
dns
jasnell
approved these changes
Feb 6, 2017
Contributor
|
landed in 7db7e47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hintsvalue will be a number. To specify more than one hints,their corresponding bits have to be set. So bitwise OR should be used
instead of logical OR.
PR-URL: #11037
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Timothy Gu timothygu99@gmail.com
Reviewed-By: Sam Roberts vieuxtech@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
Affected core subsystem(s)
doc