codeandlearn: use strictEqual instead of equal by ftatiezedev · Pull Request #10478 · nodejs/node

ftatiezedev · 2016-12-28T02:22:46Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

jasnell · 2016-12-28T02:30:39Z

This looks good but the commit log message needs a bit of fixing up...
Can you make the first line of the commit message something like:

test: use strictEqual in test-http-server

EDIT by gibfahn: Cut commit message suggestion to <50 chars

mscdex · 2016-12-28T03:14:48Z

test/parallel/test-http-server.js


  var hello = new RegExp('/hello');
-  assert.equal(true, hello.exec(server_response) != null);
+  assert.strictEqual(true, hello.exec(server_response) != null);


Maybe we can change this assertion and the one below to instead be like:

assert.notEqual(null, hello.exec(server_response));

I agree. Making the changes now.

mscdex · 2016-12-28T04:48:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5610/

cjihrig · 2016-12-28T18:04:14Z

test/parallel/test-http-server.js


  var hello = new RegExp('/hello');
-  assert.equal(true, hello.exec(server_response) != null);
+  assert.notEqual(null, hello.exec(server_response));


Can you use notStrictEqual() here.

Ah yes, I missed that it was a regexp so it will always return null on failure. notStrictEqual() is better here and below.

cjihrig · 2016-12-28T18:04:22Z

test/parallel/test-http-server.js


  var quit = new RegExp('/quit');
-  assert.equal(true, quit.exec(server_response) != null);
+  assert.notEqual(null, quit.exec(server_response));


italoacasas · 2016-12-29T01:45:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5620/console

jasnell · 2016-12-29T04:06:22Z

@cjihrig .. does this LGTY?

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell · 2016-12-29T19:35:13Z

Landed in 3d290d2

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codeandlearn: use strictEqual instead of equal

40ecf79

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 28, 2016

jasnell approved these changes Dec 28, 2016

View reviewed changes

mscdex reviewed Dec 28, 2016

View reviewed changes

mscdex added the http Issues or PRs related to the http subsystem. label Dec 28, 2016

codeandlearn: updating assertion to use notEqual.

09451b0

nodejs-github-bot added lts-watch-v6.x labels Dec 28, 2016

cjihrig requested changes Dec 28, 2016

View reviewed changes

codeandlearn: using notStrictEqual.

f316fb4

nodejs-github-bot added lts-watch-v6.x labels Dec 29, 2016

italoacasas approved these changes Dec 29, 2016

View reviewed changes

cjihrig approved these changes Dec 29, 2016

View reviewed changes

jasnell pushed a commit that referenced this pull request Dec 29, 2016

test: use strictEqual in test-http-server

3d290d2

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell closed this Dec 29, 2016

evanlucas mentioned this pull request Jan 3, 2017

v7.4.0 release proposal #10589

Merged

evanlucas pushed a commit that referenced this pull request Jan 3, 2017

test: use strictEqual in test-http-server

4e12849

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

evanlucas pushed a commit that referenced this pull request Jan 4, 2017

test: use strictEqual in test-http-server

0a0c190

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jan 23, 2017

test: use strictEqual in test-http-server

7c26a5c

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added the land-on-v4.x label Jan 23, 2017

MylesBorins added land-on-v6.x and removed lts-watch-v4.x labels Jan 23, 2017

MylesBorins pushed a commit that referenced this pull request Jan 23, 2017

test: use strictEqual in test-http-server

7e6ccb7

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jan 23, 2017

test: use strictEqual in test-http-server

2eba1d5

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jan 24, 2017

test: use strictEqual in test-http-server

3fb1e26

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jan 24, 2017

test: use strictEqual in test-http-server

fa53e90

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This was referenced Jan 24, 2017

v4.8.0 proposal #10973

Merged

v6.10.0 proposal #10974

Merged

MylesBorins pushed a commit that referenced this pull request Jan 31, 2017

test: use strictEqual in test-http-server

82f4a33

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request Feb 1, 2017

test: use strictEqual in test-http-server

b74bc51

PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

snyk-bot mentioned this pull request Apr 24, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#97

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#109

Open

This was referenced Apr 24, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#122

Open

[Snyk] Fix for 17 vulnerabilities aliscco/alisco-node#127

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#128

Open

This was referenced Apr 25, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#177

Open

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#182

Open

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#183

Open

aliscco mentioned this pull request Apr 26, 2023

[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#195

Open

snyk-bot mentioned this pull request Apr 26, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#249

Open

aliscco mentioned this pull request Apr 28, 2023

[Snyk] Fix for 10 vulnerabilities aliscco/alisco-node#309

Open

snyk-bot mentioned this pull request Apr 28, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#336

Open

aliscco mentioned this pull request Apr 29, 2023

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#356

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

codeandlearn: use strictEqual instead of equal#10478

codeandlearn: use strictEqual instead of equal#10478
ftatiezedev wants to merge 3 commits intonodejs:masterfrom
ftatiezedev:codeandlearn

ftatiezedev commented Dec 28, 2016

Uh oh!

jasnell commented Dec 28, 2016 •

edited by gibfahn

Loading

Uh oh!

mscdex Dec 28, 2016 •

edited

Loading

Uh oh!

ftatieze Dec 28, 2016

Uh oh!

mscdex commented Dec 28, 2016

Uh oh!

cjihrig Dec 28, 2016

Uh oh!

mscdex Dec 28, 2016

Uh oh!

cjihrig Dec 28, 2016

Uh oh!

italoacasas commented Dec 29, 2016

Uh oh!

jasnell commented Dec 29, 2016

Uh oh!

jasnell commented Dec 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

ftatiezedev commented Dec 28, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

jasnell commented Dec 28, 2016 • edited by gibfahn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mscdex Dec 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ftatieze Dec 28, 2016

Choose a reason for hiding this comment

Uh oh!

mscdex commented Dec 28, 2016

Uh oh!

cjihrig Dec 28, 2016

Choose a reason for hiding this comment

Uh oh!

mscdex Dec 28, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrig Dec 28, 2016

Choose a reason for hiding this comment

Uh oh!

italoacasas commented Dec 29, 2016

Uh oh!

jasnell commented Dec 29, 2016

Uh oh!

jasnell commented Dec 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jasnell commented Dec 28, 2016 •

edited by gibfahn

Loading

mscdex Dec 28, 2016 •

edited

Loading