test test-child-process-stdin.js: change assert.ok to assert.strictEqual#10418
test test-child-process-stdin.js: change assert.ok to assert.strictEqual#10418navulirs wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Definitely. In another few minutes. |
|
@sriluvan sorry my bad, I see another PR with that changes #10022, why you don't make this changes in the original PR ? |
|
Ok. Didn't know I can update a open PR. will do it this time. |
|
Yes you can update your PR, add a commit with the changes in the same branch, squash and then use the |
|
I did like you suggested After commit executed this - Git push --force origin sriluvan Got message everything up-to-date Let me know if you don't see my changes |
|
I don't see your changes, the process should be: 1 - change to the branch |
|
Closing in favor of #10420 |
test test-child-process-stdin.js: change assert.ok to assert.strictEqual
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Description of change