test: refactor the code in test-http-connect#10397
Closed
edsadr wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor the code in test-http-connect#10397edsadr wants to merge 1 commit intonodejs:masterfrom
edsadr wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
test
cjihrig
requested changes
Dec 21, 2016
test/parallel/test-http-connect.js
Outdated
Contributor
There was a problem hiding this comment.
I would avoid adding common.mustCall() to the data handler. The number of events emitted can potentially be different, and it isn't really needed for the test.
test/parallel/test-http-connect.js
Outdated
test/parallel/test-http-connect.js
Outdated
Contributor
There was a problem hiding this comment.
By using common.mustCall(), I think these variables can be eliminated completely, as can this exit event handler.
edsadr
force-pushed
the
test-http-connect
branch
from
b419178 to
f936dea
Compare
Member
Author
|
@cjihrig , just implemented your suggestions |
cjihrig
approved these changes
Dec 22, 2016
jasnell
approved these changes
Dec 23, 2016
lpinca
reviewed
Dec 26, 2016
test/parallel/test-http-connect.js
Outdated
Member
There was a problem hiding this comment.
Nit: can't this be removed now? I mean the clientRequestClosed flag.
edsadr
force-pushed
the
test-http-connect
branch
from
f936dea to
dfd7a21
Compare
Member
Author
|
@lpinca removed as suggested, please set the CI again |
Member
lpinca
reviewed
Dec 26, 2016
test/parallel/test-http-connect.js
Outdated
Member
There was a problem hiding this comment.
Nit: this can also probably be removed.
lpinca
reviewed
Dec 26, 2016
test/parallel/test-http-connect.js
Outdated
lpinca
approved these changes
Dec 26, 2016
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables
edsadr
force-pushed
the
test-http-connect
branch
from
dfd7a21 to
4dc1aae
Compare
Member
Author
|
@lpinca removed those too |
Member
|
New CI before landing: https://ci.nodejs.org/job/node-test-pull-request/5635/ |
Member
|
Landed in 72a8488. |
lpinca
pushed a commit
that referenced
this pull request
Dec 30, 2016
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables PR-URL: #10397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables PR-URL: #10397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables PR-URL: #10397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables PR-URL: #10397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables PR-URL: #10397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error and unnecessary variables PR-URL: #10397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Description of change