test: refactor assert.equal, update syntax to ES6#10190
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor assert.equal, update syntax to ES6#10190Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
buffer
3 tasks
Member
Author
Member
Author
|
cc / fyi @prietoguy |
cjihrig
approved these changes
Dec 9, 2016
thefourtheye
approved these changes
Dec 9, 2016
gibfahn
approved these changes
Dec 9, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 12, 2016
PR-URL: nodejs#10190 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
Author
|
Landed in 10891a1. Thanks for the contribution, @prietoguy! 🎉 |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
PR-URL: #10190 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test buffer
Description of change
alternative for #9914