test: refactor test-dgram-exclusive-implicit-bind.js#10066
Closed
cesarhq wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor test-dgram-exclusive-implicit-bind.js#10066cesarhq wants to merge 1 commit intonodejs:masterfrom
cesarhq wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Dec 1, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Code LGTM. The commit message is too long though.
julianduque
added
code-and-learn
* assert.equal() -> assert.strictEqual()
cesarhq
force-pushed
the
cleanup-test-dgram-exclusive-implicit-bind
branch
from
032165d to
7493746
Compare
santigimeno
approved these changes
Dec 1, 2016
addaleax
approved these changes
Dec 2, 2016
Member
Member
|
Landed in 4601d5a, thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Dec 4, 2016
* assert.equal() -> assert.strictEqual() PR-URL: #10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
* assert.equal() -> assert.strictEqual() PR-URL: #10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* assert.equal() -> assert.strictEqual() PR-URL: nodejs#10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* assert.equal() -> assert.strictEqual() PR-URL: nodejs#10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
* assert.equal() -> assert.strictEqual() PR-URL: #10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* assert.equal() -> assert.strictEqual() PR-URL: #10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* assert.equal() -> assert.strictEqual() PR-URL: #10066 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change