Closed
Conversation
imyller
added
buffer
jreading
force-pushed
the
nina-tasks3
branch
7 times, most recently
from
618e40a to
5724dd2
Compare
Member
|
Just curious, is there a reason you created a new file instead of adding it to test/parallel/test-icu-transcode.js? |
Author
|
No reason other than I did not see that file. 😄 I'll move this test there. |
cjihrig
reviewed
Dec 2, 2016
test/parallel/test-icu-transcode.js
Outdated
Contributor
There was a problem hiding this comment.
If you're testing the entire error message, you can add ^ and $ to the regular expression.
cjihrig
reviewed
Dec 2, 2016
test/parallel/test-icu-transcode.js
Outdated
cjihrig
approved these changes
Dec 2, 2016
jasnell
reviewed
Dec 5, 2016
test/parallel/test-icu-transcode.js
Outdated
Member
There was a problem hiding this comment.
Would be better to test the full error message here:
/^Error: Unable to transcode Buffer [U_ILLEGAL_ARGUMENT_ERROR]$/This test is for argument validation in transcode. feedback from approvers; full regex error msg & new line
Member
|
Landed 9f58e02 Thanks for the contribution. |
italoacasas
pushed a commit
that referenced
this pull request
Dec 12, 2016
This test is for argument validation in transcode. PR-URL: #10043 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
This test is for argument validation in transcode. PR-URL: #10043 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This test is for argument validation in transcode.