test: updated test-domain-exit-dispose-again#10003
Closed
Ethan-Arrowood wants to merge 1 commit intonodejs:masterfrom
Ethan-Arrowood:ethan-test
Closed
test: updated test-domain-exit-dispose-again#10003Ethan-Arrowood wants to merge 1 commit intonodejs:masterfrom Ethan-Arrowood:ethan-test
Ethan-Arrowood wants to merge 1 commit intonodejs:masterfrom
Ethan-Arrowood:ethan-test
Conversation
setTimeout at 49:5 requires two arguments, so I added TIMEOUT_DURATION as the second argument. On lines 72 and 73 changed assert.equal() to assert.strictEqual().
imyller
added
the
code-and-learn
Fishrock123
approved these changes
Dec 6, 2016
Member
|
CI failures are unrelated. |
Trott
requested changes
Dec 7, 2016
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
The timeout duration for a timer that should never run should be set to the minimum IMO, which is 1.
| disposalFailed = true; | ||
| process.exit(1); | ||
| }); | ||
| }, TIMEOUT_DURATION); |
Member
There was a problem hiding this comment.
I think this should be 1 instead of TIMEOUT_DURATION.
Member
|
Landing. Will fix the one nit while doing so. |
Trott
approved these changes
Dec 7, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 7, 2016
setTimeout at 49:5 requires two arguments. On lines 72 and 73 changed assert.equal() to assert.strictEqual(). PR-URL: nodejs#10003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in ac78812. |
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
setTimeout at 49:5 requires two arguments. On lines 72 and 73 changed assert.equal() to assert.strictEqual(). PR-URL: #10003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
setTimeout at 49:5 requires two arguments. On lines 72 and 73 changed assert.equal() to assert.strictEqual(). PR-URL: nodejs#10003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
setTimeout at 49:5 requires two arguments. On lines 72 and 73 changed assert.equal() to assert.strictEqual(). PR-URL: #10003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
setTimeout at 49:5 requires two arguments. On lines 72 and 73 changed assert.equal() to assert.strictEqual(). PR-URL: #10003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
setTimeout at 49:5 requires two arguments. On lines 72 and 73 changed assert.equal() to assert.strictEqual(). PR-URL: #10003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
setTimeout at 49:5 requires two arguments, so I added
TIMEOUT_DURATION as the second argument. On lines 72
and 73 changed assert.equal() to assert.strictEqual().