Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 35 35
Lines 1750 1750
=======================================
Hits 1445 1445
Misses 305 305 Continue to review full report at Codecov.
|
fanchenkong1
force-pushed
the
add-ittapi-to-v8-dep
branch
from
9c25ca2 to
bfb71f8
Compare
targos
approved these changes
Jul 14, 2021
Member
|
Thanks, will merge after nodejs/node#39374 has landed. |
Add ittapi to the list of V8 dependencies, which is used by VTune JIT profiling. Refs: nodejs/node#39374
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
This change add ittapi to the V8 dependency list. The ittapi library is used in V8 to profile JIT-compiled JavaScript code and support instrumentation for JavaScript code.
Refs: nodejs/node#39374