fix(wpt): download files as buffer instead of text#535
Merged
joyeecheung merged 1 commit intonodejs:masterfrom Feb 22, 2021
Merged
fix(wpt): download files as buffer instead of text#535joyeecheung merged 1 commit intonodejs:masterfrom
joyeecheung merged 1 commit intonodejs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 82.51% 82.51%
=======================================
Files 35 35
Lines 1744 1744
=======================================
Hits 1439 1439
Misses 305 305 Continue to review full report at Codecov.
|
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
This was referenced Feb 21, 2021
Trott
approved these changes
Feb 21, 2021
joyeecheung
approved these changes
Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are binary files in the WPT repository and downloading them as
text corrupts them.
Refs: nodejs/node#37294