src: change guards for BigInt to NAPI_VERSION > 5#694
Closed
gabrielschulhof wants to merge 2 commits intonodejs:masterfrom
Closed
src: change guards for BigInt to NAPI_VERSION > 5#694gabrielschulhof wants to merge 2 commits intonodejs:masterfrom
gabrielschulhof wants to merge 2 commits intonodejs:masterfrom
Conversation
NickNaso
reviewed
Mar 30, 2020
Member
NickNaso
left a comment
NickNaso
left a comment
There was a problem hiding this comment.
I think that we need to make changes on test/binding.cc and in the specific in the following lines of code:
- https://github.com/nodejs/node-addon-api/blob/master/test/binding.cc#L20
- https://github.com/nodejs/node-addon-api/blob/master/test/binding.cc#L76
As reported in the comments we should use NAPI_VERSION instead of NODE_MAJOR_VERISION.
Contributor
Author
|
@NickNaso I have added the changes you requested to the PR. |
NickNaso
reviewed
Mar 30, 2020
Member
NickNaso
left a comment
NickNaso
left a comment
There was a problem hiding this comment.
Sorry I missed in the previous review. Maybe we should consider to remove the comment placed before the guards. Apart this it's good for me.
NickNaso
reviewed
Mar 30, 2020
| @@ -17,7 +17,7 @@ Object InitBasicTypesValue(Env env); | |||
| // Currently experimental guard with NODE_MAJOR_VERISION in which it was | |||
Member
There was a problem hiding this comment.
I think that this comment is not necessary anymore.
| @@ -73,7 +73,7 @@ Object Init(Env env, Object exports) { | |||
| // Currently experimental guard with NODE_MAJOR_VERISION in which it was | |||
Member
There was a problem hiding this comment.
I think that this comment is not necessary anymore.
devsnek
approved these changes
Mar 30, 2020
gabrielschulhof
force-pushed
the
change-bigint-guards
branch
from
dce9dd0 to
507b343
Compare
added 2 commits
April 6, 2020 09:03
We need to cast the `nullptr` to the templated type of the `AsyncProgressQueueWorker`. Fixes: nodejs#695 PR-URL: nodejs#696 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly.
gabrielschulhof
force-pushed
the
change-bigint-guards
branch
from
507b343 to
44e7688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have made the decision that we shall include
BigIntintoN-API 6, we can change the guards for the
BigIntwrappersaccordingly.