Add ArrayBuffer::Detach() and ::IsDetached()#659
Closed
tniessen wants to merge 2 commits intonodejs:masterfrom
Closed
Add ArrayBuffer::Detach() and ::IsDetached()#659tniessen wants to merge 2 commits intonodejs:masterfrom
tniessen wants to merge 2 commits intonodejs:masterfrom
Conversation
tniessen
force-pushed
the
add-detach-functions
branch
from
8d7c515 to
bcd03dd
Compare
Member
|
Note that |
Member
|
@tniessen do you need any more info to progress this? |
Member
|
@tniessen are you still planning to work on this? |
Member
Author
|
Yes, sorry @mhdawson, I do intend to work on this. I didn't find much time recently. |
Member
|
@tniessen np, just wanted to check in as I was doing some cleanup on the issues. |
gabrielschulhof
approved these changes
Aug 6, 2020
Contributor
gabrielschulhof
left a comment
gabrielschulhof
left a comment
There was a problem hiding this comment.
This needs a rebase, but otherwise LGTM.
Contributor
gabrielschulhof
left a comment
gabrielschulhof
left a comment
There was a problem hiding this comment.
Oh, wait, and documentation 🙂
Member
|
@tniessen ping. |
tniessen
force-pushed
the
add-detach-functions
branch
from
bcd03dd to
ad9f5b0
Compare
Member
Author
|
Sorry it took me so long to get back to this! |
Member
Member
|
Looks good landing |
mhdawson
pushed a commit
that referenced
this pull request
Nov 5, 2020
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: #659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Member
|
Landed as c9563ca |
Superlokkus
pushed a commit
to Superlokkus/node-addon-api
that referenced
this pull request
Nov 20, 2020
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: nodejs#659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: nodejs/node-addon-api#659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: nodejs/node-addon-api#659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: nodejs/node-addon-api#659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Refs: nodejs/node#29768 Refs: nodejs/node#30613 PR-URL: nodejs/node-addon-api#659 Refs: nodejs/node#29768 Refs: nodejs/node#30613 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know what the proper guard is, seems like
NAPI_EXPERIMENTALandNAPI_VERSIONare not good enough.Refs: nodejs/node#29768
Refs: nodejs/node#30613