Closed
Conversation
Since original submit for nodejs#292 warnings were tightened through nodejs#315 causing the bigint test to fail to compile Fix the compile failure
Merged
Member
Author
|
Landing as this won't be controversial and unbreaks the CI. |
Member
Author
|
Landed as 79ee838 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Since original submit for nodejs/node-addon-api#292 warnings were tightened through nodejs/node-addon-api#315 causing the bigint test to fail to compile Fix the compile failure PR-URL: nodejs/node-addon-api#345 Reviewed-By: : None, landed to unbreak CI
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Since original submit for nodejs/node-addon-api#292 warnings were tightened through nodejs/node-addon-api#315 causing the bigint test to fail to compile Fix the compile failure PR-URL: nodejs/node-addon-api#345 Reviewed-By: : None, landed to unbreak CI
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Since original submit for nodejs/node-addon-api#292 warnings were tightened through nodejs/node-addon-api#315 causing the bigint test to fail to compile Fix the compile failure PR-URL: nodejs/node-addon-api#345 Reviewed-By: : None, landed to unbreak CI
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Since original submit for nodejs/node-addon-api#292 warnings were tightened through nodejs/node-addon-api#315 causing the bigint test to fail to compile Fix the compile failure PR-URL: nodejs/node-addon-api#345 Reviewed-By: : None, landed to unbreak CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since original submit for
#292 warnings
were tightened through #315
causing the bigint test to fail to compile
Fix the compile failure