Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 77.52% 77.14% -0.38%
==========================================
Files 34 34
Lines 5027 5027
==========================================
- Hits 3897 3878 -19
- Misses 1130 1149 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let's merely upgrade the GitHub Actions. |
|
Excellent - The bump of actions, especially to the official setup-node, is very useful. Edit: I thought this fixed https://github.com/cclauss/llnode/blob/6ac110d4f6fea7b898b01e4b67669d502b15c07d/.github/workflows/push.yml#L35 |
|
Rebased. Also fixed |
|
Hey @cclauss Would you mind bumping llnode/test/plugin/inspect-test.js Line 669 in ff75da7 to 30000 and llnode/test/plugin/workqueue-test.js Line 29 in ff75da7 to 60000 And set the defaults to 40000 Line 45 in ff75da7 Line 173 in ff75da7 Thanks |
Refs: nodejs#403 Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Anton Whalley <anton@venshare.com>
|
@No9 Your re-review, please. |
|
Hey @cclauss I think these have landed in 404 as you requested https://github.com/nodejs/llnode/pull/404/files#diff-f3fc934cf0d89bdf07de358896ff90f1202585df812cf606206d1830a9949811R37 |
|
Closing in favor of #404 |
Refs: #403 Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Anton Whalley <anton@venshare.com>
Uh oh!
There was an error while loading. Please reload this page.