src: inspcet arguments from an Error object stack#271
Closed
mmarchini wants to merge 1 commit intonodejs:masterfrom
Closed
src: inspcet arguments from an Error object stack#271mmarchini wants to merge 1 commit intonodejs:masterfrom
mmarchini wants to merge 1 commit intonodejs:masterfrom
Conversation
This is useful when the process aborts later than a thrown error (for example, when there's an async rethrow or an unhandled Promise rejection). V8 changes to make this possible landed in v8/v8@3724a125.
Contributor
Author
|
Still need to add some tests here. Also, there's no way to test this feature with current Node.js release lines, so we might want to wait to land it. |
Contributor
|
Typo in the commit message: inspcet -> inspect |
4 tasks
Contributor
Author
|
Recent-ish changes on V8 rendered this feature less useful (it's less likely users will get an Error object with the raw stack we expect), so I'm closing it for now. We can revisit it if situation changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when the process aborts later than a thrown error (for
example, when there's an async rethrow or an unhandled Promise
rejection). V8 changes to make this possible landed in
v8/v8@3724a125.