Use temporary GNUPGHOME directory when using gpg in image builds#1901
Use temporary GNUPGHOME directory when using gpg in image builds#1901SimenB merged 1 commit intonodejs:mainfrom
GNUPGHOME directory when using gpg in image builds#1901Conversation
5008f2f to
65d976a
Compare
|
Rebased onto I think a decision should be made to prefer either grouping all cleaning operations, or to stick with a 'clean as soon as possible' policy, to group related logic more tightly together. |
65d976a to
72958a9
Compare
|
Rebased this onto |
|
@SimenB @PeterDaveHello any objection to merging this? |
|
None at all 😃 |
|
Created PR on the official-images repo (docker-library/official-images#15565). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
| && apt-get update && apt-get install -y ca-certificates curl wget gnupg dirmngr xz-utils libatomic1 --no-install-recommends \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 | ||
| && export GNUPGHOME="$(mktemp -d)" \ |
There was a problem hiding this comment.
I think this variable doesn't need to be exported?
Description
As a follow-up to #1895 (comment), this PR alters the debian-based images to use a temporary
GNUPGHOMEdirectory to be more consistent with other official image and possibly prevent future issues with new GPG versions.Motivation and Context
Discussion on #1895.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist