Explain the npm verbosity in the node image#113
Conversation
Starefossen
force-pushed
the
docs/npm-verbose-output
branch
from
540ee32 to
f8c7511
Compare
|
LGTM |
|
LGTM |
README.md
Outdated
|
|
||
| ## Verbosity | ||
|
|
||
| By default Node.js Docker Image has NPM log verbosity set to `verbose` instead |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
One small nit, but other-wise looks good |
README.md
Outdated
| By default Node.js Docker Image has NPM log verbosity set to `verbose` instead | ||
| of the default `warn`. This is because of the way Docker is isolated from the | ||
| host operating system and you are not guaranteed to be able to retrieve the | ||
| `npm-debug.log` file when something breaks. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I think the technical sections are 🔥 I think we need to explain the rationale behind the decision in terms newcomers to both Docker and Node will understand while striking a balance with being technically correct. |
Starefossen
force-pushed
the
docs/npm-verbose-output
branch
3 times, most recently
from
31203ab to
87bf354
Compare
|
I have incorporated the feedback and added a section to explain the rationale behind the decision of changing the verbosity level of npm. Feel free to nitpick 😄 |
Close: nodejs#57 Related: nodejs/docker-iojs#36 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen
force-pushed
the
docs/npm-verbose-output
branch
from
87bf354 to
95a5dd9
Compare
|
LGTM! |
|
Merging this as it's gone 5 months without objection |
PR-URL #2997 Related: nodejs/node#12220 nodejs/docker-node#411 nodejs/docker-node#412 nodejs/docker-node#113 Signed-off-by: Hans Kristian Flaatten <hans@starefossen.com>
5 participants
Attempts to explain the rationale behind the
NPM_CONFIG_LOGLEVEL.Close: #57
Related: nodejs/docker-iojs#36
Signed-off-by: Hans Kristian Flaatten hans.kristian.flaatten@dnt.no