Skip to content

CI: Test 3.7, resume testing nipy extras #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 22, 2018

Conversation

effigies
Copy link
Member

List of changes proposed in this PR (pull-request)

  • Add Python 3.7-dev to test matrix
  • Remove "fmri" extra removed in 3500213

@satra Should fmri instead be replaced with nipy in Travis?

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@djarecka
Copy link
Collaborator

@effigies - if you want you can also test py 3.7 from xenial, travis-ci/travis-ci#9815

@effigies
Copy link
Member Author

I think I tried that over in nibabel and couldn't make it work.

@djarecka
Copy link
Collaborator

@effigies - this is the syntax I used in pynidm. Probably can be done bettrer, but it works. Hopefully, this is only temporary, so either xenial or 3.7-dev works fine.

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #2682 into master will decrease coverage by 3.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage    67.6%   64.09%   -3.51%     
==========================================
  Files         340      338       -2     
  Lines       43145    43094      -51     
  Branches     5349     5346       -3     
==========================================
- Hits        29170    27623    -1547     
- Misses      13273    14413    +1140     
- Partials      702     1058     +356
Flag Coverage Δ
#smoketests ?
#unittests 64.09% <ø> (-0.99%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/nitime/analysis.py 43.15% <0%> (-36.85%) ⬇️
nipype/interfaces/freesurfer/base.py 49.59% <0%> (-30.9%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35.39% <0%> (-29.21%) ⬇️
nipype/interfaces/spm/base.py 58.41% <0%> (-29.05%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.99%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6247b3...026d68c. Read the comment docs.

@effigies
Copy link
Member Author

That seems to only grab one entry from the env matrix...

@effigies
Copy link
Member Author

So it looks like only Xenial has 3.7, and only Trusty has 3.4. So not sure there's going to be a nice Travis matrix solution to get both without double-enumerating the environment.

@effigies
Copy link
Member Author

I think it probably makes the most sense to move to Xenial, and duplicate the matrix for 3.4, as that's going to be end-of-life soonest.

@effigies effigies changed the title CI: Test 3.7-dev, remove fmri extra from Travis CI: Test 3.7, remove fmri extra from Travis Aug 15, 2018
@effigies
Copy link
Member Author

Okay, this is set. @satra We haven't been testing interfaces that require nipy extras on Travis, so I haven't re-added it, but let me know if you think we should.

@effigies
Copy link
Member Author

effigies commented Aug 15, 2018

(I cancelled the Circle tests, since this is just futzing with Travis.)

@satra
Copy link
Member

satra commented Aug 15, 2018

@effigies - i think we should add nipy tests on travis in the same arm where dependencies (spm, fsl, etc.,.) are added.

@effigies
Copy link
Member Author

I'm interpreting that as INSTALL_DEB_DEPENDENCIES=true.

@effigies
Copy link
Member Author

Looks like dipy doesn't have wheels for 3.7 yet, and we can't build it in Travis. Is it reasonable to ask them to build the wheel, or should we find some way of excluding dipy from 3.7 tests for now?

@satra
Copy link
Member

satra commented Aug 15, 2018

i think it's reasonable to ask, i don't know how much work it would be for them. @arokem - is there a practical obstacle to dipy wheels for 3.7 (now that it is available)?

@effigies effigies mentioned this pull request Aug 21, 2018
@effigies effigies changed the title CI: Test 3.7, remove fmri extra from Travis CI: Test 3.7, resume testing nipy extras Aug 21, 2018
@effigies effigies merged commit 9fb7930 into nipy:master Aug 22, 2018
@effigies effigies deleted the ci/travis_update branch August 22, 2018 14:14
@effigies effigies added this to the 1.1.3 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants