-
Notifications
You must be signed in to change notification settings - Fork 532
CI: Test 3.7, resume testing nipy extras #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@effigies - if you want you can also test py 3.7 from xenial, travis-ci/travis-ci#9815 |
I think I tried that over in nibabel and couldn't make it work. |
@effigies - this is the syntax I used in pynidm. Probably can be done bettrer, but it works. Hopefully, this is only temporary, so either xenial or 3.7-dev works fine. |
Codecov Report
@@ Coverage Diff @@
## master #2682 +/- ##
==========================================
- Coverage 67.6% 64.09% -3.51%
==========================================
Files 340 338 -2
Lines 43145 43094 -51
Branches 5349 5346 -3
==========================================
- Hits 29170 27623 -1547
- Misses 13273 14413 +1140
- Partials 702 1058 +356
Continue to review full report at Codecov.
|
That seems to only grab one entry from the env matrix... |
So it looks like only Xenial has 3.7, and only Trusty has 3.4. So not sure there's going to be a nice Travis matrix solution to get both without double-enumerating the environment. |
I think it probably makes the most sense to move to Xenial, and duplicate the matrix for 3.4, as that's going to be end-of-life soonest. |
Okay, this is set. @satra We haven't been testing interfaces that require |
(I cancelled the Circle tests, since this is just futzing with Travis.) |
@effigies - i think we should add nipy tests on travis in the same arm where dependencies (spm, fsl, etc.,.) are added. |
I'm interpreting that as |
Looks like dipy doesn't have wheels for 3.7 yet, and we can't build it in Travis. Is it reasonable to ask them to build the wheel, or should we find some way of excluding dipy from 3.7 tests for now? |
i think it's reasonable to ask, i don't know how much work it would be for them. @arokem - is there a practical obstacle to dipy wheels for 3.7 (now that it is available)? |
List of changes proposed in this PR (pull-request)
@satra Should
fmri
instead be replaced withnipy
in Travis?Acknowledgment