Add configurable timeout for gunicorn workers #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickjj
requested changes
Jun 28, 2024
src/config/gunicorn.py
Outdated
|
|
||
| reload = bool(strtobool(os.getenv("WEB_RELOAD", "false"))) | ||
|
|
||
| timeout = int(os.getenv("GUNICORN_TIMEOUT", 120)) |
There was a problem hiding this comment.
Can you rename this to WEB_TIMEOUT?
.env.example
Outdated
| #export WEB_RELOAD=false | ||
| export WEB_RELOAD=true | ||
|
|
||
| # GUNICORN_TIMEOUT sets the timeout for gunicorn workers, defaults to 120 |
There was a problem hiding this comment.
# Configure the timeout value in seconds for gunicorn.
nickjj
requested changes
Jun 28, 2024
.env.example
Outdated
| # seconds. | ||
| #export GUNICORN_TIMEOUT= | ||
| # Configure the timeout value in seconds for gunicorn. | ||
| #export WEB_TIMEOUT= |
There was a problem hiding this comment.
Given it defaults to 120, can you also set #export WEB_TIMEOUT=120 here so folks know what the default value is? Currently it's missing the 120 value.
|
Looks good, can you roll up the commits to a single one with a message of "Add configurable gunicorn timeout value"? |
Winnie-Fred
force-pushed
the
gunicorn-timeout
branch
from
a3e1e0e to
adce3df
Compare
|
Done, I have rolled up the commits. |
nickjj
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
timeoutsetting to gunicorn config which is configurable via environment variable.