NH-3087 pre-work

[IronsUK]

https://nhibernate.jira.com/browse/NH-3087

Some pre-work refactoring to support multi tenancy feature, to be implemented later.

• Refactored EntityKey and CacheKey creation to be centralized to ISessionImplementor (implemented in AbstractSessionImpl)
• Key creation takes tenantIdentifier into account
• Added MultiTenancyStrategy enum for SessionFactory configuration and integrated into Settings
• Changed SessionFactoryImpl.EvictEntity(string entityName, object id) and EvictCollection(string roleName, object id) to throw an exception when the multi-tenancy strategy is not NONE and there is no session context

No change to the public API and no new features added. Tests passed ok after refactoring. I would have added a test for the SessionFactory cache eviction change but it looks like those methods are untested currently.

[oskarb]

Paul,

Thanks for the patch, however there were some issues:

• The NHibernate project use tabs for indenting.
• The patch touch a large number of files because of the EntityKey centralization. Understandable, but I would have preferred a separate commit with just the centralization and nothing else.

It has also unfortunately taken some time to get to this, so the patch required some tweaks for merging anyway.

As a first step I have extracted the EntityKey and CacheKey creation centralization and pushed that to master. I have pushed the remainder of the patch, with some indenting cleaned up and rebased to current master, to a separate branch: https://github.com/oskarb/nhibernate-core/tree/NH-3087-prelim. At the moment I haven't decided how to proceed with this. It might not be a good idea to merge settings for multi-tenancy when those settings really aren't implemented yet.

A couple of more tips:

• You may want to set up you git with a proper name/email since this show up in the commit log.
• I recommend you use separate topic branches for all work - doing work directly on local master tends to make merging with upstream master more difficult.

[IronsUK]

Thanks for reviewing this and for the information. I would like to continue to contribute to this feature though it could be a while before I can work on it.

What is the most appropriate way for me to continue? Branch your NH-3087-prelim branch and push patches to that?

[oskarb]

Hi Paul,

Sorry about late reply. For continuing the work, I think the best would be to create a new topic branch from current upstream master (to avoid the commits from your initial work "polluting" the subsequent pull request), and then cherry-pick from the branch I created. Try to divide the work logically into several smaller commits (easer to review), avoid large whitespace-changes, and avoid changing the new-line character (makes reviewing and history tracking more difficult).

[oskarb]

Closing this PR. Some parts were merged, others where placed in a branch as noted above and in the Jira issue in case someone wants to pick it up and continue.