NH-3700 - Remove CodeDom BytecodeProviderImpl #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CodeDom BytecodeProviderImpl was intended for .Net 1.1 and has not been the default for many years. It doesn't actually work currently.
|
There are currently zero tests that cover the results of the CodeDom code generation, and the code it generates is incorrect. The first error in the generated code is |
| @@ -15,7 +15,6 @@ | |||
| <xs:documentation> | |||
| There are 3 default short-cut values | |||
| - lcg : default for .NET2.0 and higher. | |||
| - codedom : CodeDOM-based bytecode provider (mostly for .NET1.1). | |||
| - null : Disable the reflection optimization completely. | |||
There was a problem hiding this comment.
There are 3 should be changed to There are 2.
Update documentation text.
fredericDelaporte
approved these changes
Sep 16, 2017
hazzik
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is NH-3700.
The CodeDom BytecodeProviderImpl was intended for .Net 1.1 and has not been the default for many years. It doesn't actually work currently.
This was slated for v5.0. It's not really a breaking change as it hasn't been usable; see NH-2798.