Fix fetching properties from unmapped base class #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Jul 11, 2023
| resultOperator.RelationMember.ReflectedType.FullName).FirstOrDefault(); | ||
| if (!string.IsNullOrEmpty(entityName)) | ||
| foreach (var entityName in queryModelVisitor.VisitorParameters.SessionFactory | ||
| .GetImplementors(resultOperator.RelationMember.ReflectedType.FullName)) |
There was a problem hiding this comment.
The main problem with resultOperator.RelationMember.ReflectedType that we don't know the actual entity type. Only declaring type of fetched property (which is not equal to entity type if this property is from some base class). That's why we need to check all implementors.
Ideally, we should retrieve entity from query source (my plan for 5.5)
There was a problem hiding this comment.
The main problem here that we don't know the actual entity type.
Actually we do. It is in query source as you've said.
hazzik
approved these changes
Jul 11, 2023
|
Btw, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3352
Annoyingly, it’s caused by my non-regression fix #3320. On the bright side, it uncovered a few flaws in the current Fetch implementation which I plan to fix in 5.5
Apart from regression it fixes broken in 5.3 fetching lazy properties from base unmapped class.