-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Case for Invalid SQL with property-ref on property using a formula #3309
Merged
fredericDelaporte
merged 10 commits into
nhibernate:master
from
PapisKang:GH3513-many-to-one-targetting-formula
Feb 6, 2024
Merged
Test Case for Invalid SQL with property-ref on property using a formula #3309
fredericDelaporte
merged 10 commits into
nhibernate:master
from
PapisKang:GH3513-many-to-one-targetting-formula
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operty-ref targets a property which has a formula invalid sql is generated The test case is not complete yet. It seems that we cant target a property which has a formula with a many to one relationship
…b.com/PapisKang/nhibernate-core into GH3513-many-to-one-targetting-formula
fredericDelaporte
approved these changes
Feb 6, 2024
} | ||
|
||
[Test] | ||
[Explicit("Not fixed yet")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not fixed yet, marking as explicit allows the test case to be ignored by the CI. This will have to be removed once the trouble is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case for #1313 is not complete yet cause i ve some troubles with the issue description.
The description of the issue defines a situation where a many to one relationship with property-ref is targetting a property having a formula.
But after spending a lot of time on the documentation, i feel like it s something that is not allowed anymore.
A formula is not a column in the database (it is just calculated), so i m asking how can i target a formula with a many to one relationship ? Also specifying both column and formula attributes is invalid
<property name="SerialNumber" unique="true" type="string" column="SerialNumber" formula="(select Id from Customer where Customer.Id = Id)" />
AnyWay, i tried to write a test case and i hope someone would help to understand what we re trying to do here.