-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NUnit3TestAdapter to fix "Unknown framework version 7.0" #3302
Upgrade NUnit3TestAdapter to fix "Unknown framework version 7.0" #3302
Conversation
According to this need to upgrade only nunit-console 3.15.4 or 3.16.0 nunit/nunit3-vs-adapter#1090 (comment) |
@fredericDelaporte how do you run tests? I have .NET 7 installed and don't seem to have a problem.
I tried from ShowBuildMenu.bat option C -- works fine on both 5.4.x and master branches |
That is running inside Visual Studio (not Code) that does fail. I use the test explorer to run only the test I am interested in. I have seen the trouble with Visual Studio Community 2022 edition, 17.5.5. (Maybe the last time I have done that, but on 5.3.x, I was using my professional laptop with a VS2022 Professional.) |
Downgrading the engine to .2 version dodges the bug we have in our SetSnapShot utility and still allows me to test in VS 2022. (Professional, currently I am on my professional laptop without access to my personal one. I do repro the trouble on VS 2022 Professional when attempting to test from a cleaned-up solution reloaded in a freshly opened VS, before the NUnit test adapter upgrade.) For reference, here is the test output in VS when failing to launch tests:
With the upgraded test adapter, no trouble and output is:
|
Turns out I have the same issue in Rider. |
Updating the test adapter to 4.3.0 fixes the issue for me. |
I can no more run tests in the 5.4.x branch due to some error in the NUnit discovery engine when having dotnet 7.0 installed. (I do not have the issue in the 5.3.x branch, likely because it uses an old enough NUnit version, but I have not checked that was the actual reason.)
Upgrading it fixes the issue.