Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINQ subqueries wrongly altered by SelectClauseVisitor #3271

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Mar 25, 2023

SelectClauseVisitor modifies select clause for retrieval adding post processing lambdas SelectClauseVisitor.ProjectionExpression that are never executed for subqueries.

For instance, the following select expression a.Name ?? "Test" is transformed simply to a.Name with post processing lambda (result) => result ?? "Test". Such lambdas are simply ignored for subqueries executing modified query with different logic.

It seems a very old bug but let's fix in 5.4

@fredericDelaporte fredericDelaporte added this to the 5.4.2 milestone Mar 26, 2023
@fredericDelaporte fredericDelaporte changed the title Skip SelectClauseVisitor for LINQ subqueries LINQ subqueries wrongly altered by SelectClauseVisitor Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants