Linq: add enum Equals and object Equals support

[tykovec]

No description provided.

[tykovec]

Seems not so easy with enum equals as it is boxed into object.Equals(object) expression (what leads to problem in my first iteration with BaseHqlGeneratorForMethod approach)

[bahusoid]

We have EqualsGenerator class with registrations for various Equals methods. Can't it be simply extended with additional registration for Enum.Equals?

[tykovec]

We have EqualsGenerator class with registrations for various Equals methods. Can't it be simply extended with additional registration for Enum.Equals?

I tried it but it is throwing exception:

System.InvalidOperationException : The binary operator Equal is not defined for the types 'NHibernate.DomainModel.Northwind.Entities.Gender' and 'System.Object'.

Stack Trace: 
Expression.GetEqualityComparisonOperator(ExpressionType binaryType, String opName, Expression left, Expression right, Boolean liftToNull)
Expression.Equal(Expression left, Expression right, Boolean liftToNull, MethodInfo method)
Expression.Equal(Expression left, Expression right)
EqualsGenerator.BuildHql(MethodInfo method, Expression targetObject, ReadOnlyCollection arguments, HqlTreeBuilder treeBuilder, IHqlExpressionVisitor visitor) line 79
HqlGeneratorExpressionVisitor.VisitMethodCallExpression(MethodCallExpression expression) line 605

GetMethodBasedBinaryOperator is expecting that types on both sides of equal operation are same ...

[bahusoid]

Stacktrace shows the same source of exception:

EqualsGenerator.BuildHql

I can't look into it right now. But I'm pretty sure EqualsGenerator.BuildHql can be adjusted (like casting to object one of argument) to make it work

[tykovec]

I tried it but Enum.Equals is [MethodImplAttribute(MethodImplOptions.InternalCall)] and when i try to get method ReflectHelper.GetMethodDefinition<Enum>(x => x.Equals(default(Enum))) this is evaluated to object.Equals and then is EqualsGenerator class used for object.Equals comparison which is not wanted.

[bahusoid]

then is EqualsGenerator class used for object.Equals comparison which is not wanted.

Why? Does it cause any particular issues (except mentioned problem from EqualsGenerator.BuildHql)? Maybe we just need to register object.Equals.

[hazzik]

hi @tykovec could you please remove unrelated formatting changes?

[tykovec]

hi @tykovec could you please remove unrelated formatting changes?

done, btw were you not thinking about some code cleanup rules or something like that, white spaces and spacing is really mess ...

[tykovec]

@hazzik how can i retrigger teamcity build, has some issue with cleanup ....

[fredericDelaporte]

I have relaunched them.

[hazzik]

@fredericDelaporte I actually had to restart the build agent, sorry, did not have time to re-queue tests

[tykovec]

@bahusoid @hazzik -> i have repushed changes, now there is no problem with team city builds, needs successful merge something more?