Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Contains subquery with parameter #3220

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Fix Contains subquery with parameter #3220

merged 3 commits into from
Jan 18, 2023

Conversation

bahusoid
Copy link
Member

Fixes #3218

fredericDelaporte
fredericDelaporte approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It started working by chance for your case in 5.3 due to other bug :)

So, should we consider this a regression having happened in 5.3, and then should we target 5.3.x instead?

@bahusoid
Copy link
Member Author

Yes, we should backport it to 5.3. But what's the plan? Didn't we simply cherry-pick changes for older branches in separate PR?
Or are you planning on 5.3 -> 5.4 -> master merge?

@fredericDelaporte
Copy link
Member

If the fix can target 5.3.x "as is" and be simply merged to 5.4.x, it is then easier to target 5.3.x. If 5.3.x needs a different fix, better target 5.4.x and backport.

@bahusoid bahusoid changed the base branch from 5.4.x to 5.3.x January 16, 2023 10:06
@bahusoid
Copy link
Member Author

it is then easier to target 5.3.x

Done

@bahusoid bahusoid force-pushed the gh3218 branch 3 times, most recently from ef91f69 to 98a35a1 Compare January 16, 2023 16:13
@fredericDelaporte fredericDelaporte added this to the 5.3.15 milestone Jan 16, 2023
@bahusoid

This comment was marked as resolved.

Sign in to view
@bahusoid bahusoid changed the title Fix Contains subquery with parameter WIP Fix Contains subquery with parameter Jan 17, 2023
@bahusoid bahusoid changed the title WIP Fix Contains subquery with parameter Fix Contains subquery with parameter Jan 18, 2023
@bahusoid bahusoid merged commit ac5e2b6 into nhibernate:5.3.x Jan 18, 2023
@bahusoid bahusoid mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.15
Development

Successfully merging this pull request may close these issues.
2 participants
@bahusoid @fredericDelaporte