Support caching queries with autodiscovered types #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
reviewed
Oct 16, 2022
hazzik
reviewed
Oct 16, 2022
|
I think adding the aliases in the middle can break already cached objects because internal format of the cache will change. Can we add indexes to the end? Or what do you think? |
bahusoid
reviewed
Oct 17, 2022
bahusoid
reviewed
Oct 18, 2022
Co-authored-by: Roman Artiukhin <bahusdrive@gmail.com>
fredericDelaporte
force-pushed
the
GH3169
branch
from
c322b2b to
ec0c5a0
Compare
bahusoid
reviewed
Oct 23, 2022
And fix the empty case.
Comment on lines
-274
to
+310
| if (finalReturnTypes[i] == null) | ||
| if (cacheables[i] == null) |
There was a problem hiding this comment.
Checking for null return types as a marker of cache miss is wrong for empty result lists with type auto-discovery: their return types are null, but that is no cache miss. So instead, we need to nullify the cacheable when it is a cache miss due to its timestamp.
bahusoid
reviewed
Oct 23, 2022
Co-authored-by: Roman Artiukhin <bahusdrive@gmail.com>
hazzik
reviewed
Oct 24, 2022
hazzik
reviewed
Oct 24, 2022
hazzik
reviewed
Oct 24, 2022
hazzik
reviewed
Oct 24, 2022
Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
bahusoid
previously approved these changes
Oct 25, 2022
hazzik
approved these changes
Oct 27, 2022
bahusoid
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-fix #3169