Fix possible ERROR log when parsing join in hql #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Jul 15, 2021
| @@ -725,6 +723,7 @@ void PrepareFilterParameter() | |||
|
|
|||
| // Generate an explicit join for the root dot node. The implied joins will be collected and passed up | |||
| // to the root dot node. | |||
| dot.SkipSemiResolve = true; | |||
There was a problem hiding this comment.
It's either implicit or entity join. So skip any processing that's not fully resolve this node.
hazzik
approved these changes
Jul 15, 2021
bahusoid
added a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Jul 24, 2021
bahusoid
added a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #2810
Fix tries to process node as implicit join first (as
GetImplementorsrequired for entity join caches results, and we want to avoid caching query parts representing implicit join)Fixes #2855