Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double param type guessing and better NULL parameter handling in LINQ #2723

Merged
merged 11 commits into from
Aug 26, 2022
Merged

Avoid double param type guessing and better NULL parameter handling in LINQ #2723

merged 11 commits into from
Aug 26, 2022

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Apr 7, 2021 •
edited
Loading

And added test cases for #1166

@bahusoid bahusoid changed the title Do not set guessed type as expected parameter type Do not set guessed type as expected parameter type in LINQ Apr 7, 2021
@bahusoid bahusoid changed the title Do not set guessed type as expected parameter type in LINQ WIP Do not set guessed type as expected parameter type in LINQ Apr 7, 2021
@bahusoid bahusoid mentioned this pull request May 31, 2021
Merged
@bahusoid bahusoid changed the title WIP Do not set guessed type as expected parameter type in LINQ Do not set guessed type as expected parameter type in LINQ Jun 3, 2021
@hazzik

This comment has been minimized.

Sign in to view
@bahusoid

This comment has been minimized.

Sign in to view
@bahusoid

This comment has been minimized.

Sign in to view
@bahusoid bahusoid force-pushed the nh3565 branch 2 times, most recently from a911ea2 to 0c9d64a Compare December 23, 2021 12:53
@bahusoid bahusoid changed the title Do not set guessed type as expected parameter type in LINQ WIP Do not set guessed type as expected parameter type in LINQ Dec 23, 2021
@bahusoid bahusoid changed the title WIP Do not set guessed type as expected parameter type in LINQ Do not set guessed type as expected parameter type in LINQ Dec 23, 2021
@bahusoid bahusoid mentioned this pull request Dec 26, 2021
Closed
@fredericDelaporte fredericDelaporte added this to the next minor milestone Apr 18, 2022
@fredericDelaporte
Copy link
Member

There is a conflict with #2964 to resolve.

@hazzik
Copy link
Member

hazzik commented Jul 21, 2022

Hopefully I've resolved the conflict correctly. @maca88 and @bahusoid could you please check.

@maca88
Copy link
Contributor

maca88 commented Jul 23, 2022 •
edited
Loading

From my point of view the conflict was correctly resolved. Even if the modification in GetCharsGenerator class fixes the tests, I would still leave the change from #2964 as there could be other cases (e.g. with user defined hql functions) for which we don't have tests.

@bahusoid
Copy link
Member Author

bahusoid commented Aug 8, 2022

It seems some of the changes no longer needed. I need to look at it more closely when I have time...

@bahusoid bahusoid changed the title Do not set guessed type as expected parameter type in LINQ WIP Do not set guessed type as expected parameter type in LINQ Aug 8, 2022
@bahusoid bahusoid changed the title WIP Do not set guessed type as expected parameter type in LINQ Avoid double param type guessing and better NULL parameter handling in LINQ Aug 11, 2022
@bahusoid
Copy link
Member Author

#2964 implements most of the logic of original PR. Now this PR is transformed in parameter handling improvement so changed the name.

@hazzik hazzik enabled auto-merge (squash) August 25, 2022 11:28
@hazzik hazzik merged commit e6b8dbc into nhibernate:master Aug 26, 2022
@bahusoid bahusoid mentioned this pull request Mar 14, 2023
Merged
bahusoid added a commit that referenced this pull request Mar 16, 2023
@bahusoid
Cleanup guessed parameters handling in hql (#3255)
d419ab3 
Partial revert of no longer needed logic from #2964 (obsoleted by #2723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte left review comments

Assignees
No one assigned
Labels
c: Linq Provider p: Minor r: Fixed t: Improvement
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bahusoid @hazzik @fredericDelaporte @maca88