Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AsyncGenerator to 0.19.1 #2605

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Upgrade AsyncGenerator to 0.19.1 #2605

merged 3 commits into from
Nov 19, 2020

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Nov 13, 2020

With this upgrade we can now generate async code also with .NET Core 3.1 and 5.0. Based on the installed .NET Core version, the appropriate async generator binaries will be used, so the global.json won't be needed anymore.

hazzik
hazzik previously approved these changes Nov 13, 2020
View reviewed changes
@hazzik hazzik added this to the next minor milestone Nov 13, 2020
@maca88 maca88 changed the title Upgrade AsyncGenerator to 0.19.0 WIP Upgrade AsyncGenerator to 0.19.0 Nov 16, 2020
@hazzik hazzik changed the title WIP Upgrade AsyncGenerator to 0.19.0 WIP Upgrade AsyncGenerator to 0.19.1 Nov 16, 2020
@hazzik
Copy link
Member

hazzik commented Nov 16, 2020

I'll redo it to use a tool instead.

@hazzik
Copy link
Member

hazzik commented Nov 16, 2020

@maca88 or you want to do it?

@maca88
Copy link
Contributor Author

maca88 commented Nov 16, 2020

I'll redo it to use a tool instead.

Sure, why not. Ideally would be nice to port all tools but most likely there are some that are not published as a .NET tool.

@maca88 or you want to do it?

I am fine, you can proceed with the conversion.

@hazzik
Copy link
Member

hazzik commented Nov 16, 2020

Ideally would be nice to port all tools but most likely there are some that are not published as a .NET tool.

Yes, it would be great. However, only AsyncGenerator and GitReleaseManager has tool packages.

@fredericDelaporte
Copy link
Member

Has the Wip removal been overlooked, or is there still something more to do?

@maca88 maca88 changed the title WIP Upgrade AsyncGenerator to 0.19.1 Upgrade AsyncGenerator to 0.19.1 Nov 17, 2020
@maca88
Copy link
Contributor Author

maca88 commented Nov 17, 2020

I've added WIP for upgrading from 0.19.0 to 0.19.1, which has been done. Removed it, as I think it is ready to be merged.

@hazzik
Copy link
Member

hazzik commented Nov 18, 2020

With this change, I think, the SDK 3+ would be required.

fredericDelaporte
fredericDelaporte approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK 3.0 is indeed required, and keeping a global.json asking for a lower sdk causes the async generation to fail on the tool restore command.

@hazzik hazzik merged commit 58e3cb2 into nhibernate:master Nov 19, 2020
@maca88 maca88 mentioned this pull request Dec 13, 2021
Closed
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
97a92c4 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
@fredericDelaporte fredericDelaporte mentioned this pull request Sep 4, 2022
Merged
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
c7303d4 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
aace054 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
dc68a31 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
ad436cd 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
edcaaba 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
26c00bc 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
b0fb9d5 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
a9c1079 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
c2a0ffc 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
958f413 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 4, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
2e79408 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 5, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
10a5191 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 5, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
53af8be 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 11, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
a8468f4 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to fredericDelaporte/NHibernate-Caches that referenced this pull request Sep 11, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
b8ab109 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
fredericDelaporte added a commit to nhibernate/NHibernate-Caches that referenced this pull request Sep 11, 2022
@fredericDelaporte @hazzik @maca88
Automatically generate async code on pull request
86d3112 
Copied from nhibernate/nhibernate-core#3133 and
nhibernate/nhibernate-core#2605.

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Co-authored-by: maca88 <bostjan.markezic@siol.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: Toolset p: Minor r: Fixed t: Task
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@maca88 @hazzik @fredericDelaporte