Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw for LINQ queries on unmapped entities #2504

Merged
merged 8 commits into from
Sep 8, 2020

Conversation

bahusoid
Copy link
Member

Fixes #1106

@bahusoid bahusoid changed the title Throw for LINQ queries on unmapped entities WIP Throw for LINQ queries on unmapped entities Aug 30, 2020
@bahusoid
Copy link
Member Author

bahusoid commented Aug 31, 2020

I simply skipped invalid tests in FunctionTests as they didn't really test anything (as those tests are simply based on the fact that query can be executed and dump results to output).

P.S. We need to do something with tests inside Linq folder.
As now all of them are executed under LinqReadonlyTestsContext . So it's problematic to add some non readonly test or test not based on Northwind database. And mixing non-readonly and readonly tests can lead to some vague issues (like missing sequence on firebird for unrelated tests).

@bahusoid bahusoid changed the title WIP Throw for LINQ queries on unmapped entities Throw for LINQ queries on unmapped entities Aug 31, 2020
@hazzik
Copy link
Member

hazzik commented Aug 31, 2020

As I understand it the idea of LinqReadOnlyTextContext was exactly about that - running read only tests. So, IMO, non read only tests should go somewhere else.

@bahusoid

This comment has been minimized.

@bahusoid

This comment has been minimized.

hazzik
hazzik previously approved these changes Sep 7, 2020
@hazzik hazzik added the t: Fix label Sep 7, 2020
@hazzik hazzik added this to the next minor milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NH-2978 - LINQ: Queries for unmapped entity types return empty result set
2 participants