Support count distinct on function in hql #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Aug 30, 2020
Comment on lines
+630
to
+631
| : ( distinctAll aggregateArgument ) => (distinctAll aggregateArgument) | ||
| | aggregateArgument |
There was a problem hiding this comment.
An obvious ( ( DISTINCT | ALL )? aggregateArgument ) gives:
[fatal] rule aggregate has non-LL(*) decision due to recursive rule invocations reachable from alts 1,2. Resolve by left-factoring or using syntactic predicates or using backtrack=true option.
So had to use this syntactic predicate rule with code duplication..
hazzik
approved these changes
Aug 30, 2020
hazzik
added
c: Core
p: Minor
t: Improvement
t: Fix
and removed
c: Core
p: Minor
t: Improvement
labels
This was referenced Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1285